Add support for fine-grained error location lines in Python tracebacks #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See: PEP 657
Python 3.11 makes it easier to identify where on the line a problem
occurred. This is achieved with the error location lines.
We need to skip such lines when parsing the traceback, otherwise
we won't identify the exception name correctly (See: rhbz#2137473).
Example:
Traceback (most recent call last):
File "test.py", line 2, in <module>
x['a']['b']['c']['d'] = 1
~~~~~~~~~~~^^^^^
TypeError: 'NoneType' object is not subscriptable
Signed-off-by: Michal Srb <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #334 +/- ##
==========================================
- Coverage 63.13% 63.13% -0.01%
==========================================
Files 40 40
Lines 7352 7351 -1
Branches 1232 1232
==========================================
- Hits 4642 4641 -1
Misses 2180 2180
Partials 530 530
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: PEP 657
Python 3.11 makes it easier to identify where on the line a problem occurred. This is achieved with the error location lines. We need to skip such lines when parsing the traceback, otherwise we won't identify the exception name correctly (See: rhbz#2137473).
Example:
Traceback (most recent call last):
File "test.py", line 2, in
x['a']['b']['c']['d'] = 1
~~~~~~~~~~~^^^^^
TypeError: 'NoneType' object is not subscriptable
Signed-off-by: Michal Srb [email protected]